Skip to content

➡️ Move TypeScript and Husky to devDependencies, document SCM hooks #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2021
Merged

➡️ Move TypeScript and Husky to devDependencies, document SCM hooks #372

merged 4 commits into from
Mar 19, 2021

Conversation

@jrolfs
Copy link
Collaborator

@jrolfs jrolfs commented Mar 19, 2021 •
edited
Loading

  • Move TypeScript and Husky to devDependencies
  • Upgrade TypeScript to 4.2.3
  • Document source control hook scripts in readme with Husky as a suggestion, not a requirement

@jrolfs jrolfs self-assigned this Mar 19, 2021
@jrolfs jrolfs requested a review from fiddlerwoaroof March 19, 2021 21:05
@jrolfs jrolfs mentioned this pull request Mar 19, 2021
Closed
@codecov
Copy link

codecov bot commented Mar 19, 2021 •
edited
Loading

Codecov Report

Merging #372 (f5be67f) into main (b9d3af6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files          26       26           
  Lines         319      319           
  Branches       66       66           
=======================================
  Hits          299      299           
  Misses         19       19           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d3af6...f5be67f. Read the comment docs.

@jrolfs jrolfs force-pushed the fix/dev-dependencies branch from 7816bb8 to 42efe72 Compare March 19, 2021 21:10
@github-actions github-actions bot force-pushed the fix/dev-dependencies branch 2 times, most recently from 32e3a4b to 289b5b0 Compare March 19, 2021 21:18
fiddlerwoaroof
fiddlerwoaroof approved these changes Mar 19, 2021
View reviewed changes
Copy link

@fiddlerwoaroof fiddlerwoaroof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot force-pushed the fix/dev-dependencies branch from 289b5b0 to 41ac4d4 Compare March 19, 2021 21:22
@github-actions github-actions bot force-pushed the fix/dev-dependencies branch from 41ac4d4 to f5be67f Compare March 19, 2021 21:25
@jrolfs jrolfs added the automerge dd this label to any PRs that you want merged as soon as CI passes label Mar 19, 2021
@github-actions github-actions bot merged commit b50626d into main Mar 19, 2021
@github-actions github-actions bot deleted the fix/dev-dependencies branch March 19, 2021 21:27
@github-actions github-actions bot removed the automerge dd this label to any PRs that you want merged as soon as CI passes label Mar 19, 2021
@jrolfs
Copy link
Collaborator Author

jrolfs commented Mar 19, 2021

🎉 This PR is included in version 5.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fiddlerwoaroof fiddlerwoaroof fiddlerwoaroof approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jrolfs jrolfs

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jrolfs @fiddlerwoaroof